We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OmniAuth 2.0 was released includes to resolved CSRF vulnerability CVE-2015-9284 and some behaviors changed.
See below the release note for details. https://github.com/omniauth/omniauth/releases/tag/v2.0.0
If an OmniAuth Strategy has overridden callback_url, it is needed to follow changes because of the callback_path changes.
callback_url
I think this library is also the target. https://github.com/ginjo/omniauth-slack/blob/master/lib/omniauth/strategies/slack.rb#L199
In case of using OmniAuth 2.0 and script_name, the redirect url now includes the script_name twice so it might occur redirect url mismatch error.
script_name
I suggest this library should release 2 versions for correspond to OmniAuth 1.x and 2.0 series.
I’m going to make pull requests.
The text was updated successfully, but these errors were encountered:
ginjo#16 Add a testcase to confirm callback_url when setting script_n…
db25092
…ame.
ginjo#16 Add dependency constraint for omniauth 1.x
64159d5
ginjo#16 Allow for OmniAuth 2.0 series
a500f65
I opened two PRs (#17 #18) Could you review theses?
Sorry, something went wrong.
No branches or pull requests
OmniAuth 2.0 was released includes to resolved CSRF vulnerability CVE-2015-9284 and some behaviors changed.
See below the release note for details.
https://github.com/omniauth/omniauth/releases/tag/v2.0.0
If an OmniAuth Strategy has overridden
callback_url
, it is needed to follow changes because ofthe callback_path changes.
I think this library is also the target.
https://github.com/ginjo/omniauth-slack/blob/master/lib/omniauth/strategies/slack.rb#L199
In case of using OmniAuth 2.0 and
script_name
, the redirect url now includes thescript_name
twice so it might occur redirect url mismatch error.I suggest this library should release 2 versions for correspond to OmniAuth 1.x and 2.0 series.
I’m going to make pull requests.
The text was updated successfully, but these errors were encountered: