-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: value error recherche prestataire => passage django 4.2 => 5.1 #1635
Conversation
34491dc
to
1ac487f
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
1ac487f
to
51bbba5
Compare
@Guilouf , j'ai fais le tour des DepreciationWarning sur la version Django 4 et corrigé en grande partie. Il en reste juste deux qu'on peut ignorer pour le moment:
L'autre Warning est sur le dsfr_form mais nous ne le mettons pas à jour ici et les formulaires ne fonctionne pas sans : Donc j'approuve la PR, et tu vas pouvoir merger ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG avec la correction d'un max de DeprecationWarning 🦾
Il y a aussi |
Quoi ?
Erreur 500 à cause de caractères nulls: http://localhost:8000/prestataires/?sectors=1%00%EF%BF%BD%EF%BF%BD%EF%BF%BD%EF%BF%BD%252527%252522
Pourquoi ?
C'est un bug django https://code.djangoproject.com/ticket/35483 qui a été patché en version 5.1 django/django@38ad710
Comment ?
Une bonne occasion de passer en version 5 ?