-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding field creation prompts (was: Editing Bidirectional Relationships) #94
Comments
Huh, I thought for sure I had provided for "reverse editing" relationships, I will check this out tomorrow, thanks for the report. |
What I'm seeing is that you can edit the relationship field from either record, but the prompts ("this label", "the other label") don't change depending on which record you're on. ie, the label prompts are "backwards" if you're editing from the record that doesn't actually own the field instance. Is that consistent with what you're seeing? |
Yes I tested it again, and it seems to be that way. Sorry I actually did it because I did the role association wrong with brother and sister and wanted to change it and probably I then did not look at the labels and did it wrong again and therefore it did not change. |
Okay, no problem -- this is a real issue (it has annoyed me in other circumstances), but one that's going to take a little bit of thought. Let me sit on this for a bit. |
Relevant to github #94, though it's not actually used anywhere yet. * ebdb.el (ebdb-read-string-override): New dynamic variable that can be bound around calls to ebdb-read-string, to augment or override the prompt. (ebdb-read-string): Check this variable. Also, we're now appending the final ": " in this call, so remove that from the prompt in all callers of ebdb-read-string.
Very minor issue regarding #86
A short example
I have two contacts Alice and Bob,
I add a relationship of Bob as the boyfriend of Alice, everything works fine due to your work in the other issue, and Alice becomes the girlfriend of Bob.
Now they marry and I want to update their relationship.
Now if I edit Alice's relationship to Bob (from Alice's entry) I cannot update the relationship while if I do it from Bob's entry I can update it.
Finally there is probably potential for auto-guessing the corresponding role if you keep track of the gender of the contact, but most probably that is not worth the hassle
The text was updated successfully, but these errors were encountered: