Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OSO endpoint and queries #3672

Merged
merged 5 commits into from
Oct 8, 2024
Merged

update OSO endpoint and queries #3672

merged 5 commits into from
Oct 8, 2024

Conversation

MasterHW
Copy link
Member

@MasterHW MasterHW commented Oct 6, 2024

Fixes: #3669

Description

https://linear.app/gitcoin/issue/PAR-438/update-oso-endpoint-and-queries
With current OSO models it is not straightforward to retrieve code velocity data. Updated that field to instead reflect OSO's activeDeveloperCount6Months field for a sense of active developers.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@MasterHW MasterHW requested review from a team as code owners October 6, 2024 21:47
Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 9:17pm

@MasterHW
Copy link
Member Author

MasterHW commented Oct 6, 2024

known issue: when browsing through applications in explorer, Impact Stats will not populate the page after visiting a project with no stats (even if the application you're looking at does have them). page refresh fixes this. caching/cookie issue?

@MasterHW
Copy link
Member Author

MasterHW commented Oct 7, 2024

known issue: when browsing through applications in explorer, Impact Stats will not populate the page after visiting a project with no stats (even if the application you're looking at does have them). page refresh fixes this. caching/cookie issue?

believe this is fixed. improved logic determining when stats are queried to account for circumstances where stats have already been queried, but not for the currently viewed project.

Copy link
Contributor

@veganbeef veganbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one style suggestion

packages/grant-explorer/src/features/api/oso.ts Outdated Show resolved Hide resolved
@MasterHW MasterHW merged commit 7c95b97 into main Oct 8, 2024
14 checks passed
@MasterHW MasterHW deleted the fix-oso branch October 8, 2024 13:34
Copy link

sentry-io bot commented Oct 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: no stats returned getStatsFor(features/api/oso) View Issue
  • ‼️ Error: internal error: {"response":{"errors":[{"message":"internal error","path":["oso_codeMetricsByProj... getStatsFor(features/api/oso) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update OSO endpoint & queries
3 participants