Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funder Unable to Approve Worker #1985

Closed
PixelantDesign opened this issue Aug 10, 2018 · 2 comments
Closed

Funder Unable to Approve Worker #1985

PixelantDesign opened this issue Aug 10, 2018 · 2 comments
Assignees
Labels
bug This is something that isn't working as intended.

Comments

@PixelantDesign
Copy link
Contributor

PixelantDesign commented Aug 10, 2018

Describe the bug

Funder is unable to approve a worker (using metamask account that issue was funded with).
The workers who applied also do not show up for core team members with admin privileges.

Link https://github.com/Bounties-Network/bounties.network/issues/7

To Reproduce

Create an issue without logging in.

Expected behavior

Be able to pay out using correct MM account

Funder should be able to approve worker - even without being logged in.

We should maybe remove ability to fund issue without being logged in.

@owocki @thelostone-mc @SaptakS @mbeacom

Screenshots

Email Received
screen shot 2018-08-10 at 12 47 58 pm

Screenshot from my Admin Account
screen shot 2018-08-10 at 12 50 33 pm

@owocki
Copy link
Contributor

owocki commented Aug 10, 2018

http://bits.owocki.com/2f3Q1h1P342w/Screen%20Shot%202018-08-10%20at%2011.28.41%20AM.png

per convo with @PixelantDesign on gitcoin slack, this was a problem with the bounty submitter not being logged in at the time, so we can't authenticate that they're the funder when they go to approve the bounty hunter!

@mbeylin we just updated the bounty such that your github handle is the handle on the bounty. @mbeylin you should be able to approve workers now!

as a fix it twice, we're going to prevent users who aren't logged in from being able to submit bounties.

@mbeylin
Copy link

mbeylin commented Aug 10, 2018

we're going to prevent users who aren't logged in from being able to submit bounties.

Great work 👍

@PixelantDesign PixelantDesign added the bug This is something that isn't working as intended. label Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is something that isn't working as intended.
Projects
None yet
Development

No branches or pull requests

4 participants