Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode website static assets bucket name in Pulumi #10968

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Hardcode website static assets bucket name in Pulumi #10968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions infra/production/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ const staticAssetsBucket = new aws.s3.Bucket("bucket", {
website: {
indexDocument: "index.html",
},
bucket: "bucket-0427bb4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be better to but this hard coding in the environment variables section. Just would ensure that it goes to what we want exactly for the time being.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Gerald said while we were pairing that he's gonna change this section later anyway, so if you don't mind could we merge this as-is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I can approve this as a hot-fix to get the issue resolved now, but we need to make sure to follow-up on this and properly resolve it.
Not sure who will pick up the responsibility of properly fixing this. But I will make an issue in GH for myself as a reminder, and we can follow-up on that @kammerdiener

forceDestroy: true,
});

Expand Down