Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of more options #4

Open
stuart-c opened this issue Jul 22, 2020 · 12 comments
Open

Allow setting of more options #4

stuart-c opened this issue Jul 22, 2020 · 12 comments

Comments

@stuart-c
Copy link
Contributor

It would be useful if we can additionally set the following options:

  • Repository visibility (public, private, internal)
  • Delete branch upon merge
@tedivm
Copy link
Member

tedivm commented Jul 22, 2020

Great timing- I was actually going to work on this a bit this weekend, including adding some features to set the default branch (in order to help organizations transition from "master" to "main" alongside Github).

@stuart-c
Copy link
Contributor Author

Great! I was going to make a PR if I have time...

Another useful one would be setting the AD groups for teams as per https://developer.github.com/v3/teams/team_sync/

@stuart-c
Copy link
Contributor Author

I've opened #5

@tedivm
Copy link
Member

tedivm commented Jul 26, 2020

Awesome, thank you! I'm testing some changes around default branches and once that's complete I'll deploy both changes at once.

@stuart-c
Copy link
Contributor Author

When should updates run as I'm not seeing the changes I'm expecting. I'm guessing the logs aren't available anywhere?

@tedivm
Copy link
Member

tedivm commented Sep 27, 2020

I've released a bunch of upgrades today, including your changes, even more settings, the ability to take by repository topic, and default branches.

@stuart-c
Copy link
Contributor Author

You seem to have commented out the delete branch on merge stuff?

76dae7b

@tedivm
Copy link
Member

tedivm commented Oct 2, 2020

Oops, I'll get that corrected

@techxplain
Copy link

techxplain commented Nov 11, 2020

Please can you uncomment out the delete branch on merge. Thank you

@techxplain
Copy link

Hi Ted, Happy New Year. Just wondering if there is any update on getting the delete branch on merge line uncommented out?

#delete_branch_on_merge = organizer_settings.get('delete_branch_on_merge', None),

@dtroup-global
Copy link

any update on this one please?

@jobimrobinsantos-drizly
Copy link

I'd like to just say thank you for working on this project. I've been implementing it on my own org, and it's been quite helpful.

... that said ... would we be able to reimplement delete_branch_on_merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants