Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ignored version number in GHES versions automation #1881

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

henrymercer
Copy link
Contributor

The GHES versions automation looks up the GHES versions from an internal JSON file. This contains a single version number from a previous numbering scheme, which we want to ignore as it is older than the 2.* and 3.* series. Recently it was changed from 11.10.340 to 11.10, prompting the automation to open a spurious update PR.

This PR updates the ignored version number to fix the automation.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 14, 2023 11:31
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😩 but also 🙇

@henrymercer henrymercer merged commit a9313c9 into main Sep 15, 2023
344 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-update-ghes-versions branch September 15, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants