Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of from now carries vague implication of future tense #101

Closed
myii opened this issue Feb 24, 2019 · 1 comment
Closed

Use of from now carries vague implication of future tense #101

myii opened this issue Feb 24, 2019 · 1 comment

Comments

@myii
Copy link

myii commented Feb 24, 2019

Had a situation on this PR. As I filled in the comment, I saw:

myii requested review from aboe76 and noelmcloughlin 3 minutes from now

To be fair, this soon became:

myii requested review from aboe76 and noelmcloughlin 4 minutes ago

So probably just a glitch. Just to be clear, from now connotes a future event, as mentioned on this page.
@dgraham
Copy link
Contributor

dgraham commented Feb 25, 2019

This is caused by a difference in clock time on the client and server.

@dgraham dgraham closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgraham @myii