Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off of nodeIntegration to contextIsolation:true #700

Open
afonsojramos opened this issue Dec 22, 2023 · 1 comment · May be fixed by #1826
Open

Move off of nodeIntegration to contextIsolation:true #700

afonsojramos opened this issue Dec 22, 2023 · 1 comment · May be fixed by #1826
Labels
priority:high Items of high importance. Applicable to all users or use-cases refactor Refactoring of existing feature

Comments

@afonsojramos
Copy link
Member

📝 Provide a description of the new feature

For security reasons, https://www.electronjs.org/docs/latest/tutorial/context-isolation should be enabled, however, some changes are required to the way we communicate with the main thread. We should apply these changes and enable contextIsolation.

➕ Additional Information

https://stackoverflow.com/questions/71111106/nodeintegration-vs-preload-js-vs-ipc-in-electron

@setchy setchy added the refactor Refactoring of existing feature label Jan 19, 2024
@setchy setchy added the priority:high Items of high importance. Applicable to all users or use-cases label Jun 17, 2024
@setchy
Copy link
Member

setchy commented Jan 29, 2025

@setchy setchy linked a pull request Feb 8, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high Items of high importance. Applicable to all users or use-cases refactor Refactoring of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants