UserApi implement createPersonalAccessToken #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmini there are test failures. Can you check? |
|
Yes. I saw it, I will have a look… |
* adds missing scopes * factors out common logic
|
The tests were not working because the GitLab version used in the tests is too old. I changed them for now, can be revisited once we have test-containers (see #925) |
jabby
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #653
This is a rework of #686 from @maltem-za (his PR can't be edited):
ImpersonationTokenintoPersonalAccessTokenis breaking from a java point of view and because of the nested enumImpersonationToken.Scopeit is really difficult to change in a backward compatible way.6.xthe class can be renamed.