Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of react-native-i18n #783

Open
machour opened this issue Apr 23, 2018 · 2 comments
Open

Get rid of react-native-i18n #783

machour opened this issue Apr 23, 2018 · 2 comments

Comments

@machour
Copy link
Member

machour commented Apr 23, 2018

Once #777 is merged, react-native-i18n will become almost unused.

The only two things it's used for will be:

  • Retrieve the current locale (functionality provided by react-native-device-info)
  • Lookup translations strings (easily doable in t()

Getting rid of it would mean having 100% control about how our translations are handled in our code.

Opinions?

@vonovak
Copy link

vonovak commented Apr 27, 2018

I'm also migrating from react-native-i18n to js-lingui. So far so good, albeit I use the i18n.t more than <Trans> components and it took me a while to set everything up (lingui/js-lingui#176). Good luck.

@machour
Copy link
Member Author

machour commented Apr 27, 2018

@vonovak Good choice, it's an awesome lib! Actually there was a first PR to migrate to js-lingui as well (#747), but since it was too much to handle, we went for an intermediary home-made version to ease up the final migration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants