Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Git Data API for files #889

Open
Rexogamer opened this issue Sep 26, 2019 · 7 comments
Open

Use Git Data API for files #889

Rexogamer opened this issue Sep 26, 2019 · 7 comments

Comments

@Rexogamer
Copy link

This would allow us to get files up to 100mb in size.

@chinesedfan
Copy link
Member

Thanks for your suggestion. But how do users view such large files? It is hard to navigate to certain lines or do anything else.

@Rexogamer
Copy link
Author

Rexogamer commented Sep 27, 2019

...I don’t really see what that has to do with this...

Currently, we can only get file that are up to 1MB in size using the GitHub API, but if we used this API, we could get bigger files. How is it hard to navigate? Please elaborate.

@chinesedfan
Copy link
Member

I mean files that are larger than 1mb must contain thousands or more lines of codes. So even if we load them, users can't read them.

Can you provide a large file example? Like the file path in a repository. And what do you expect for which screen? The file list or the file detail?

@Rexogamer
Copy link
Author

This is simply an API change. No UI changes were requested in this issue, if that was what you were asking.

When I try to load this file,, I get the following error:
794A202B-D2B8-47AD-9B18-81BC13E479F0

@Rexogamer
Copy link
Author

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

@chinesedfan
Copy link
Member

When you say “users can’t read them”, are you suggesting the client would be laggy, or about screen size, or something else?

Yes. I admit that the current behavior is not the best one. If we updated the API without UI enhancements to handle large files, users may face new problems.

@Rexogamer
Copy link
Author

We don’t and won’t know what those issues are until we try the API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants