Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to [email protected] #883

Merged
merged 9 commits into from
Jun 30, 2019
Merged

Conversation

chinesedfan
Copy link
Member

@chinesedfan chinesedfan commented Jun 29, 2019

With this upgrade, we can enjoy the latest RN framework and related community resources.

Tested in both iOS and Android. Most use cases still work well. But there also include some bugs like,

  • The back button is missing if visiting issue screen from event screen.
  • Tabs can not response to clicks in Android.
  • Regressions of chore: fix yarn run link #513

This PR will be merged without squashing, and I will try to fix those bugs later. As many of our maintainers are inactive, my future commits may be pushed directly. (cc @gitpoint/maintainers)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 48.671% when pulling d77d06e on chinesedfan:rn-59 into 6427433 on gitpoint:master.

@chinesedfan chinesedfan merged commit d77d06e into gitpoint:master Jun 30, 2019
chinesedfan added a commit that referenced this pull request Jun 30, 2019
@chinesedfan chinesedfan mentioned this pull request Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants