You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When creating the tests for the GizaModel there were a lot of patching involved, multiple client calls, and thus in makes it harder also to test GizaAgent as it is an extension of the model.
When encountering such needs for patching in the test, that also indicates that we might have over complicated the design of GizaModel, specially the __init__.
We should aim to improve the design of this entity to:
Provide a better public API
Ease testing
Add corner cases handling
Create specific exceptions regarding model usage
This changes should not affect the current usage if the predict method, as it is basically the entrypoint used by the users, but the underlying logic can be greatly improved.
The text was updated successfully, but these errors were encountered:
Sorry... I've been having troubles with personal stuff... And I consider is better to unassign it... The ODHack6.0 is coming soon the July 25th. I'm really sorry for not completing the issue, thanks a lot for the chance @Gonmeso
I hope the new dev can fix it 🔥
When creating the tests for the
GizaModel
there were a lot of patching involved, multiple client calls, and thus in makes it harder also to testGizaAgent
as it is an extension of the model.When encountering such needs for patching in the test, that also indicates that we might have over complicated the design of
GizaModel
, specially the__init__
.We should aim to improve the design of this entity to:
This changes should not affect the current usage if the
predict
method, as it is basically the entrypoint used by the users, but the underlying logic can be greatly improved.The text was updated successfully, but these errors were encountered: