Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add responses for client tests #11

Open
Gonmeso opened this issue Jul 13, 2023 · 2 comments
Open

Add responses for client tests #11

Gonmeso opened this issue Jul 13, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Gonmeso
Copy link
Collaborator

Gonmeso commented Jul 13, 2023

Currently anything related to an outbound requests is fully mocked so encoding errors can arise as the tests don't even attempt the request.

Using responses we can mock the response for and endpoint, but requests internals are still in place so if any error comes from our side when performing the request they should arise in the tests.

@Gonmeso Gonmeso added enhancement New feature or request good first issue Good for newcomers labels Jul 13, 2023
@stevencartavia
Copy link

Hi, is this issue still unresolved?

@Gonmeso
Copy link
Collaborator Author

Gonmeso commented May 22, 2024

Hi @stevencartavia it is still unresolved so feel free to pick it up!

@stevencartavia stevencartavia removed their assignment Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants