Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the scripts in
bin/
executable. I simply ranchmod 700 bin/*
.This is needed in order to make this buildpack work with the pack command line tool and heroku/cnb-shim.
cnb-shim
cannot convert this buildpack into a cloud-native-buildpack if the executable bits are not set. Therefor the converted buildpack which you find at https://cnb-shim.herokuapp.com/v1/gjaldon/phoenix-static is broken and cannot be used withpack
.More info about the topic at hand.
It would help us a lot if this was merged. :-)
Cheers!