Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scripts executable. #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make scripts executable. #109

wants to merge 1 commit into from

Conversation

feluxe
Copy link

@feluxe feluxe commented Aug 18, 2020

This PR makes the scripts in bin/ executable. I simply ran chmod 700 bin/*.

This is needed in order to make this buildpack work with the pack command line tool and heroku/cnb-shim.

cnb-shim cannot convert this buildpack into a cloud-native-buildpack if the executable bits are not set. Therefor the converted buildpack which you find at https://cnb-shim.herokuapp.com/v1/gjaldon/phoenix-static is broken and cannot be used with pack.

More info about the topic at hand.

It would help us a lot if this was merged. :-)

Cheers!

@abtreece
Copy link

bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants