Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease of section title font size #226

Open
djarran opened this issue Oct 28, 2024 · 3 comments
Open

Decrease of section title font size #226

djarran opened this issue Oct 28, 2024 · 3 comments
Assignees

Comments

@djarran
Copy link

djarran commented Oct 28, 2024

Describe the bug
In commit 3fb243f, the section titles were changed from div to h3 with h4 styling (was this done to use semantic HTML?). This makes the text much larger, and so it is harder to fit the entire text.

Before commit
image

After commit
image

To Reproduce
Steps to reproduce the behaviour:

  1. Set course format to 'Grid'

Expected behaviour
I think it might be better to revert the font size to what it was before, but bold the text:

image

Versions (please complete the following information):

  • Moodle: 4.1
  • Format: latest MOODLE_41
  • Browser and version: Firefox
@gjb2048
Copy link
Collaborator

gjb2048 commented Oct 28, 2024

Semantic HTML, no. In line with core output, yes.

@gjb2048 gjb2048 changed the title Decrease section title font size Decrease of section title font size Oct 28, 2024
@djarran
Copy link
Author

djarran commented Oct 29, 2024

Ahh, that makes sense. Going by that, would the expected behaviour I listed be something you'd want to do? There is a .h6 style that will make this the same font size as before that could be used if so

@gjb2048
Copy link
Collaborator

gjb2048 commented Oct 30, 2024

I'll put out a solution in a future release for M4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants