Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting, lint, and typecheck in CI #129

Open
gjoseph92 opened this issue Feb 2, 2022 · 0 comments
Open

Check formatting, lint, and typecheck in CI #129

gjoseph92 opened this issue Feb 2, 2022 · 0 comments
Labels

Comments

@gjoseph92
Copy link
Owner

Format with shed.
Lint in CI with flake8.
Typecheck in CI with pyright (way faster, seems to get new features sooner than mypy, and built into vscode).

Consider also adding pre-commit hooks (and https://pre-commit.ci) for all these things. I somewhat dislike the slowdown of pre-commit hooks, but overall they are nicer than CI failures!

This was referenced Feb 2, 2022
@gjoseph92 gjoseph92 added the ci label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant