Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and relax xarray version requirement #51

Closed
gjoseph92 opened this issue May 7, 2021 · 2 comments · Fixed by #52
Closed

Bump and relax xarray version requirement #51

gjoseph92 opened this issue May 7, 2021 · 2 comments · Fixed by #52

Comments

@gjoseph92
Copy link
Owner

From #50 (@scottyhq):

Also, I'm wondering if it's possible to relax (^0) or bump (^0.18.0) the current xarray pin for the next release? Could add some matrix tests against xarray master to ensure things don't break since currently it does seem like minor bumps in xarray are more like major bumps ;) (#26 ).

xarray = "^0.17.0"

@gjoseph92
Copy link
Owner Author

Probably should just relax it, though in this case we might actually want to bump—looks like there are a couple things in the new xarray version that will benefit stackstac visualizations (faster interp logic + fixed ffill). I might go with >=0.18, <1 for now.

gjoseph92 added a commit to gjoseph92/geogif that referenced this issue May 7, 2021
Necessary for gjoseph92/stackstac#51. We have to do a crazy dance because of python-poetry/poetry#697.

**This lockfile is out of date. I've manually overridden `pyproject.toml` to an unsolveable state in order to bump the xarray version and cut a release.** This will be resolved in a future commit.
gjoseph92 added a commit to gjoseph92/geogif that referenced this issue May 7, 2021
Necessary for gjoseph92/stackstac#51. We have to do a crazy dance because of python-poetry/poetry#697.

**This lockfile is out of date. I've manually overridden `pyproject.toml` to an unsolveable state in order to bump the xarray version and cut a release.** This will be resolved in a future commit.
gjoseph92 added a commit that referenced this issue May 7, 2021
Closes #51

Allow `xarray >=0.18,<1`. Also just require `^0` for non-critical packages that aren't 1.0 yet.
gjoseph92 added a commit that referenced this issue May 7, 2021
Closes #51

Allow `xarray >=0.18,<1`. Also just require `^0` for non-critical packages that aren't 1.0 yet.
@gjoseph92
Copy link
Owner Author

stackstac 0.2.1 is out, give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant