Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement of daily codes #24

Closed
sjnoone opened this issue Feb 22, 2022 · 1 comment · Fixed by #26
Closed

Enhancement of daily codes #24

sjnoone opened this issue Feb 22, 2022 · 1 comment · Fixed by #26
Assignees
@sjnoone

Comments

@sjnoone
Copy link
Contributor

sjnoone commented Feb 22, 2022

I have enhanced bit of all the 3 daily codes and the utils.py files.
@sjnoone sjnoone self-assigned this Feb 22, 2022
sjnoone pushed a commit that referenced this issue Feb 22, 2022
#24: I made some edits to daily code
95aa7dc
@rjhd2
Copy link
Contributor

rjhd2 commented Feb 22, 2022 •
edited
Loading

PR #25 includes files from closed issue #20 in the commit. Maybe branched off branch.

This branch 20_daily_code_enhancement correctly only has changes to the 3 daily files and utils.

Intended solution

  • retain changed files (daily ones) locallly (in a temporary directory) just to be sure.
  • check out master and update (git pull)
  • check out this branch and update (git checkout 20_daily.... ; git pull). Should have edits from Add subroutines and reduce code duplication [sub-daily CDM lite] #7/Add subroutines and reduce code duplication #23 in it
  • make sure the edited files are still correct
  • make a new pull request and see if that's only got the single commit in it, continue from there.
  • close original pull request with a note to explain (open coding principles of Github means it always remains, but can just close)

@rjhd2 rjhd2 changed the title 20_daily_code_enhancement Enhancement of daily codes Mar 2, 2022
sjnoone pushed a commit that referenced this issue Mar 2, 2022
#24: copying changes from hourly to daily files
d4d1c3b
@sjnoone sjnoone mentioned this issue Mar 2, 2022
Merged
sjnoone pushed a commit that referenced this issue Mar 8, 2022
#24: I made some more edits to the code
75adcee
sjnoone added a commit that referenced this issue Mar 9, 2022
@sjnoone
enhancemnet of daily codes (#26)
cbca3b5 
* #24: copying changes from hourly to daily files

* #24: I made some more edits to the code

* #26: I made some more edits to the code

* #26: I made these last few edits to the code

Co-authored-by: Simon Noone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjnoone sjnoone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhancemnet of daily codes glamod/glamod-nuim
2 participants
@rjhd2 @sjnoone