Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magma annotation in show_doc and view_parents pages are not the same #179

Open
joewandy opened this issue Aug 3, 2021 · 1 comment
Open
Assignees
Labels

Comments

@joewandy
Copy link
Member

joewandy commented Aug 3, 2021

It seems that the codes used to retrieve magma substructure annotations when viewing the spectra information (show_doc) is not the same as when viewing mass2motif information (view_parents).

e.g. from the spectra information at http://ms2lda.org/basicviz/show_doc/848411, we see there's a magma annotation for fragment_369.3125 in motif_223.

image

but when we view the motif information for motif 223 at http://ms2lda.org/basicviz/view_parents/121444/, it's all empty:

image

I think this is because in the show_doc page, when the particular feature instance in this experiment is not annotated, it goes to retrieve the annotation for the global feature instead (e.g. massbank). The codes should probably be the same in both places?

@justinjjvanderhooft
Copy link
Collaborator

Yes, if no experiment MAGMa annotations are available, we present those from MassBank (if there) - and I agree that it would be good to have the same code at the two different places where the features are presented....

@joewandy joewandy added bug and removed enhancement labels Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants