-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gleam_json
dependency constraint
#82
Update gleam_json
dependency constraint
#82
Conversation
e92b0ae
to
d5b7175
Compare
What's the motivation here? I thought we were deliberately holding back on this one? |
Oops sorry I had no idea it was being intentionally held back. My problem is I ran into dependency resolution errors trying to add lustre_dev_tools as a dependency:
The error message is not super useful but I thought the problem might be with wisp being too restrictive with the constraint. |
Brew is stuck on 26 for some reason so if we upgrade everything to the new gleam_json most macOS users won't be able to use them. This is why Lustre docs are saying to use the old version of gleam_json currently. Looks like you've installed the new one there. |
I guess this can be fixed/merged, Erlang OTP on homebrew mac is now on 27. I guess that's the blocker, according to this comment |
d5b7175
to
d5b7d92
Compare
Why would someone prefer to use brew over something like asdf? I mean, can't just asdf be recommended over brew? |
Even if we recommended asdf it wouldn't change the fact that loads of macOS users will be using brew and breaking a really common library for them would be quite bad. Personally I use brew and like how simple it is :) |
Would you mind rebasing on main please 🙏 |
d5b7d92
to
b09f712
Compare
Done! |
Sorry Jak, I merged another PR that had this change also |
No worries! |
No description provided.