Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESOLUTION as float raises exception #355

Closed
daveisfera opened this issue Feb 6, 2024 · 4 comments
Closed

RESOLUTION as float raises exception #355

daveisfera opened this issue Feb 6, 2024 · 4 comments

Comments

@daveisfera
Copy link
Contributor

The RESOLUTION value in EXT-X-STREAM-INF is listed as being a decimal value so some outputs list it with .0 and that causes the parsing to fail ( see https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.4.2 )

@davemevans
Copy link
Contributor

RESOLUTION is defined as a decimal-resolution, which is defined in https://datatracker.ietf.org/doc/html/rfc8216#section-4.2 as two decimal-integers seperated by an x.

So my understanding is that floating point values in RESOLUTION are not legal.

That does not mean that there aren't playlists around that include floating point resolutions of course ...

@mauricioabreu
Copy link
Member

mauricioabreu commented Feb 7, 2024

I understand the approach here @daveisfera, reaching more and diverse formtas/playlists, but I'm with @davemevans here.
IPTV and pirate content have some very weird definition set (some nonsense datatypes/values). Welcoming these differences might be a good idea in theory, but in practice it could make m3u8 a simple key/value parser.

@leandromoreira
Copy link
Contributor

The main/most used video codec seems to use an unsigned integer to represent width, #356 (comment)

@daveisfera
Copy link
Contributor Author

RESOLUTION is defined as a decimal-resolution, which is defined in https://datatracker.ietf.org/doc/html/rfc8216#section-4.2 as two decimal-integers seperated by an x.

That definitely does mean that having .0 on RESOLUTION makes it out of spec, so I'm ok with rejecting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants