Run compute-sanitizer on CI checks
#1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compute-sanitizer can help disover subtle bugs that are otherwise hard to reproduce (such as the one solved in #1944).
|
@tcmoore3 @josephburkhart, since you both asked for it - here it is. Testing locally, the racecheck takes ~14 minutes compared to ~47 seconds for running without racecheck. To reduce the load on the CI systems, I run racecheck only when the |
joaander
added
the
validate
tcmoore3
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run
pytestwithcompute-sanitizertools on the GPU builds in CI.Motivation and context
Discover subtle bugs such as those in #1944.
How has this been tested?
Racecheck should fail now. After merging #1944, it should pass.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.