Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for delta account specification #47

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

janbridley
Copy link
Contributor

@janbridley janbridley commented Oct 1, 2024

Description

Accounts on delta are automatically suffixed with -cpu or -gpu. The documentation has been updated to reflect this by indicating only the account prefix must be supplied.

I'm not sure if this is the best way to document this, but Maria and I encountered (minor) confusion due to this behavior.

Checklist:

  • I have reviewed the Contributor Guidelines.
  • I agree with the terms of the Row Contributor Agreement.
  • My name is on the list of contributors (doc/src/contributors.md) in the pull request source branch.
  • I have added a change log entry to doc/src/release-notes.md.

@joaander
Copy link
Member

joaander commented Oct 2, 2024

This is mentioned in the howto guide:

> Note: NCSA Delta assigns `<prefix>-cpu` and `<prefix>-gpu` accounts. Set
> `submit_options.delta.account = "<prefix>"`. **Row** will automatically append the
> `-cpu` or `-gpu` when submitting to the CPU or GPU partitions respectively.

I agree it should also be mentioned in the Delta cluster section.

@janbridley
Copy link
Contributor Author

janbridley commented Oct 2, 2024

I updated the book to pull those specific lines from the hoot section. I think the consistency in wording is nice and it results in no text duplication (although the link could break if we update the howto page) addressed using anchors

@janbridley janbridley marked this pull request as ready for review October 2, 2024 15:25
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The anchored include is a good solution to keep duplicate information in sync.

@joaander joaander merged commit e89582b into trunk Oct 3, 2024
18 checks passed
@joaander joaander deleted the doc/delta-account-prefix branch October 3, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants