Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all desired attributes are returned by the data translators #20

Open
rosteen opened this issue Jul 27, 2020 · 3 comments
Open

Ensure all desired attributes are returned by the data translators #20

rosteen opened this issue Jul 27, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@rosteen
Copy link
Contributor

rosteen commented Jul 27, 2020

This is intended to be a round-up/continuation of a few separate discussions:

  • In PR17, @eteq and @astrofrog brought up the need to have predefined masks successfully round-trip through Glue and back - currently the mask returned by the data translators is based (I think) solely on any subset regions that are defined.

  • @ibusko brought up the need to have uncertainty (and another attribute that I don't remember off the top of my head) successfully round-trip.

  • @havok2063 and @nmearl and I were discussing handling more complex integer masks used to denote various problems a la SDSS (perhaps via a flags attribute rather than overloading mask, which is currently intended to be boolean).

Ensuring that all desired attributes are successfully ingested into a Glue data object and returned by the glue-astronomy translators may require work outside glue-astronomy, but I created this issue here since the discussion was initially motivated by changes needed in the data translators.

@rosteen rosteen added the enhancement New feature or request label Jul 27, 2020
@ibusko
Copy link

ibusko commented Jul 27, 2020

Masks should also round-trip successfully, besides the uncertainty.

@rosteen
Copy link
Contributor Author

rosteen commented Jul 27, 2020

Ah, I wasn't aware of PR 19 when I made this issue - it looks like that PR implements part of what is needed here (getting masks and uncertainty from a Spectrum1D object into the Glue data object).

@nmearl
Copy link
Contributor

nmearl commented Jul 27, 2020

Mask cannot round-trip currently, because they are overridden by the subset masks created in glue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants