Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh table sorting when data changes #9

Merged

Conversation

jfoster17
Copy link
Member

Pull Request Template

Description

Currently, if the underlying data in a component changes, the values are refreshed in the Table Viewer but sorting is not maintained. That is, if the Viewer is currently sorted on a column and the values in that column change, the table is no longer sorted. This forces a re-sort if there is a change to the underlying data and adds a test that does not pass without the change.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@astrofrog astrofrog merged commit 514354d into glue-viz:main Sep 29, 2023
32 of 34 checks passed
@jfoster17 jfoster17 deleted the refresh-table-sorting-when-data-changes branch October 31, 2023 19:45
@astrofrog astrofrog added the bug Something isn't working label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants