Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fixes #116

Merged
merged 2 commits into from
Sep 10, 2024
Merged

CI fixes #116

merged 2 commits into from
Sep 10, 2024

Conversation

Carifio24
Copy link
Member

This PR fixes two issues with the CI:

These two commits were originally on #103 but they're also needed for e.g. #115 so I decided to make this a separate PR while I work out any other CI issues with #103.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.21%. Comparing base (f6f0135) to head (bbd8bf5).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   71.21%   71.21%           
=======================================
  Files          18       18           
  Lines        1063     1063           
=======================================
  Hits          757      757           
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; one might just think about adding a replacement devdeps job, but that could as well wait until we add py313.

@dhomeier dhomeier added the no-changelog-entry-needed Skipped in Changelog generation label Sep 10, 2024
@Carifio24
Copy link
Member Author

I had thought about replacing with another devdeps job, but agreed that we can do that once we add Python 3.13 tests.

@Carifio24 Carifio24 merged commit ca4413c into glue-viz:main Sep 10, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed Skipped in Changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants