Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ExtendedComponent to glue #2351

Closed
jfoster17 opened this issue Jan 20, 2023 · 1 comment · Fixed by #2442
Closed

Add an ExtendedComponent to glue #2351

jfoster17 opened this issue Jan 20, 2023 · 1 comment · Fixed by #2442
Assignees

Comments

@jfoster17
Copy link
Member

jfoster17 commented Jan 20, 2023

Is your feature request related to a problem? Please describe it:
Some datasets such as geographic entities, features on the genome, and regions-of-interest in an image (identified algorithmically) inherently contain information about their extent in a way that glue should be able to visualize and reason about. For anything except a tiny dataset it is not feasible or desirable to translate all these extents into glue subsets.

Describe the solution you'd like:
Add an ExtendedComponent type to glue that would allow for a component to specify a shape (or set of shapes) for each element of a dataset. ExtendedComponents would describe an extant on one or more other Components in the dataset (parent_components— which may be CoordinateComponents or regular Components), and should contain references to those parent_components. Data Loaders would be responsible for parsing input data files into the appropriate components and individual Viewers would be updated to support plotting ExtendedComponents. ExtendedComponents should perhaps be hidden from the user and only used by Viewers when plotting the parent_components and transforming ROIs to SubsetStates.

Describe alternatives you've considered:
The following packages provide two partial and alternative approaches to this problem:

Additional context:

The biggest decisions to be made are:

  • How to handle ROI selections that partially intersect with an ExtendedComponent
  • How to deal with the conversion that a user will probably want to make from a subset over data points (i.e. states) to a subset over the extent of that data points (i.e. the geographic region contained within a set of states)

CaseA

CaseB

See the attached overly long PDF for my full thinking through of what this might look like.

ExtendedComponent.pdf

Related Issues

@jfoster17 jfoster17 self-assigned this Jan 20, 2023
@jfoster17
Copy link
Member Author

I'm going to take a first pass at refactoring glue-map to use this kind of approach and see how that goes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant