Support regions in imageviewer #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The codecov report here is misleading because we actually test out this code in the associated glue-qt PR. We don't generally have standalone non-qt state or layer_artist tests because they work mostly in the context of an actual viewer. This PR does not enable exporting a RegionScatterLayer as a python script. Currently RegionScatterLayers are only implemented as a layer on top of an ImageViewer where export-to-python does not work with non-image-layers anyway. |
astrofrog
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Region Layer Artist to ImageViewer
Description
This adds a
ScatterRegionLayerArtistto the ImageViewer so thatRegionDatadatasets are plotted as regions rather than points. A parallel PR for glue-qt is required to actually make this work.