Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Oracle BINARY_FLOAT offload to BigQuery FLOAT64 #180

Open
nj1973 opened this issue May 23, 2024 · 0 comments
Open

Support Oracle BINARY_FLOAT offload to BigQuery FLOAT64 #180

nj1973 opened this issue May 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nj1973
Copy link
Collaborator

nj1973 commented May 23, 2024

BINARY_FLOAT will not offload to BigQuery:

create table goe_test.tab_bf (id number(2), bf binary_float);
insert into goe_test.tab_bf values (1,1);
commit;
bin/offload -t goe_test.tab_bf
...
Exception caught at top-level
OffloadDataTypeControlsException: 4 byte binary floating point data cannot be offloaded to this backend system: BF

I believe the same change also needs to happen for a Snowflake backend.

We did this is because the 64 bit value ends up being slightly different to the 32 bit source and we used to mandate value parity. There are two options:

  1. Allow use of --double-columns as an override to force the offload
  2. Just go ahead and offload to float64, perhaps including an advisory notice

I think we should do option two, there's no other option so why stop and make the user manually intervene.

Once this is supported a columns will need to be added into any type mapping test tables where appropriate (at least integration/offload/test_data_type_controls.py, probably other places too).

@nj1973 nj1973 added the enhancement New feature or request label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant