Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move error return value to end of return value list as this is idiomatic Go #2

Open
gnewton opened this issue Feb 22, 2017 · 1 comment
Assignees

Comments

@gnewton
Copy link
Owner

gnewton commented Feb 22, 2017

The two public functions for this library returns the error return value first:

func GetManifest(filename string) (error, *Manifest)
func GetJarInfo(filename string) (error, *JarInfo)

This is not idiomatic Go. Idiomatic Go has the error return value last in the list of values returned.
I am planning to change the signature of these two functions so that the error is returned last.

THIS IS A BREAKING API CHANGE.

Pleas let me know if this impacts you.

I will work on a branch and not merge in the changes until >= 1 week after I announce it is ready in this issue.

@gnewton gnewton self-assigned this Feb 22, 2017
@soulteary
Copy link

Hope that helps, resolved legacy documentation issues @gnewton

#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants