Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add source code view doc, add r/ README #3163

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Nov 20, 2024

Description

Related to #3084

Adds a realm that teaches the user about the source code viewer in gnoweb.

It also adds a r/ root README.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@leohhhn leohhhn self-assigned this Nov 20, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 20, 2024
@leohhhn leohhhn changed the title feat(examples/docs): add source code view doc feat(examples): add source code view doc, add r/ README Nov 20, 2024
@leohhhn leohhhn requested a review from moul November 20, 2024 09:20
@moul
Copy link
Member

moul commented Nov 20, 2024

Regarding the view source demo, I suggest we add your realm now. We should soon have Gnoweb displaying the README file, if it exists, in the right block of the page. Then, we can invite people to click on "view source" from the README of hello, and remove this realm.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn leohhhn merged commit 889082f into gnolang:master Nov 21, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants