Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: timeout rpc tracking and track errors #695

Merged

Conversation

frontendphil
Copy link
Member

Part of #582

RPC tracking could get stuck when a tab would not respond. Now, each tab has 10 seconds to respond. After that the requests times out and can be tried again.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-companion-app 🛑 Canceled (Inspect) Jan 28, 2025 4:05pm

Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2025

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8891d3
Status: ✅  Deploy successful!
Preview URL: https://8e0e66b8.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://chore-add-timeout-to-rpc-tra.zodiac-pilot-29m.pages.dev

View logs

Copy link

github-actions bot commented Jan 28, 2025

Coverage Report for deployables/extension

Status Category Percentage Covered / Total
🔵 Lines 63.08% 4186 / 6636
🔵 Statements 63.08% 4186 / 6636
🔵 Functions 72.03% 237 / 329
🔵 Branches 78.63% 589 / 749
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
deployables/extension/src/background/rpcTracking.ts 89.51% 80.76% 100% 89.51% 95-96, 100-101, 105-106, 153-158, 185-186
Generated in workflow #1482 for commit b8891d3 by the Vitest Coverage Report Action

Copy link

cloudflare-workers-and-pages bot commented Jan 28, 2025

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8891d3
Status: ✅  Deploy successful!
Preview URL: https://9eb29045.zodiac-pilot.pages.dev
Branch Preview URL: https://chore-add-timeout-to-rpc-tra.zodiac-pilot.pages.dev

View logs

@frontendphil frontendphil force-pushed the chore/add-timeout-to-rpc-tracking-to-not-block-functionality branch from 429163f to b8891d3 Compare January 28, 2025 16:01
@frontendphil frontendphil enabled auto-merge (squash) January 28, 2025 16:01
@frontendphil frontendphil merged commit 52fa5f8 into main Jan 28, 2025
16 checks passed
@frontendphil frontendphil deleted the chore/add-timeout-to-rpc-tracking-to-not-block-functionality branch January 28, 2025 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant