Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent display of repository licenses in the frontend UI #33222

Closed
H0llyW00dzZ opened this issue Jan 11, 2025 · 5 comments · Fixed by #33255
Closed

Inconsistent display of repository licenses in the frontend UI #33222

H0llyW00dzZ opened this issue Jan 11, 2025 · 5 comments · Fixed by #33255
Assignees
Labels
Milestone

Comments

@H0llyW00dzZ
Copy link

Description

The repository license information is sometimes missing or disappearing from the frontend UI. This inconsistency in displaying licenses affects the user's ability to quickly identify the license of a given repository.

Expected behavior:
The repository license information should be consistently and accurately displayed in the frontend UI for all repositories, regardless of any changes made to the repository.

Actual behavior:
The repository license information is sometimes missing or disappears from the frontend UI, leading to inconsistencies in displaying licenses across different repositories.

Gitea Version

v1.23.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

For example, in the Go language repository, the license is correctly shown as BSD-3-Clause:

image

However, in another repository, such as Gitea, the license information is not displayed at all:

image

Note

In the Gitea repository, the license was previously shown as MIT License. However, after some changes were made (e.g, pull from original repository), the license information disappeared from the UI.

Git Version

v2.47.1

Operating System

Linux

How are you running Gitea?

Running on Kubernetes

Database

SQLite

@H0llyW00dzZ
Copy link
Author

Also, regarding this bug, the license information is inconsistently displayed in the frontend UI. Sometimes it appears, and other times it disappears, leading to an inconsistent user experience when viewing repository.

@lunny lunny added this to the 1.23.2 milestone Jan 11, 2025
@silverwind
Copy link
Member

Might be some UI/context bug if the display is flaky. At least the license is classified correctly when passed to licenseclassifier:

$ go run github.com/google/licenseclassifier/v2/tools/identify_license LICENSE
2025/01/13 20:15:20 Classifying license(s): /Users/silverwind/git/gitea/LICENSE
2025/01/13 20:15:20 Finished Classifying License "/Users/silverwind/git/gitea/LICENSE": 2.289541ms
/Users/silverwind/git/gitea/LICENSE Copyright:Copyright (variant: , confidence: 1, start: 1, end: 1)
/Users/silverwind/git/gitea/LICENSE Copyright:Copyright (variant: , confidence: 1, start: 2, end: 2)
/Users/silverwind/git/gitea/LICENSE MIT (variant: pristine.txt, confidence: 1, start: 4, end: 20)

@yp05327 yp05327 self-assigned this Jan 14, 2025
@yp05327
Copy link
Contributor

yp05327 commented Jan 14, 2025

Are there any error logs?
I have mirrored on in my local. Try to reproduce it.

@H0llyW00dzZ
Copy link
Author

Are there any error logs? I have mirrored on in my local. Try to reproduce it.

There is no error; it just disappears and then reappears after about 10 minutes.

@lunny
Copy link
Member

lunny commented Jan 14, 2025

Are there any error logs? I have mirrored on in my local. Try to reproduce it.

There is no error; it just disappears and then reappears after about 10 minutes.

This has been fixed by #33255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants