feat: phase 1 changes: add comments feat to unchanged lines in the pullrequest #32471
+267
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/go
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
2 times, most recently
from
e59800b to
ed80303
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
ed80303 to
abd1d2f
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
8c34f45 to
7c39ad2
Compare
rajesh-jonnalagadda
force-pushed
the
feat-32257-add-comments-unchanged-lines-and-show
branch
from
3fbf96f to
ccd797a
Compare
|
@lunny Can you please review |
|
@lunny Could you please review my changes? If the PR isn't relevant, feel free to close it. |
I will review it in the following week. |
…thub.com:rajesh-jonnalagadda/gitea into feat-32257-add-comments-unchanged-lines-and-show
|
@lunny Can you please review? |
|
Added one comment but it will display multiple times. 
|
ideally, we should not allow comment on the diffLinesection—fixed that. |
|
@lunny please review |
lunny
reviewed
Dec 10, 2024
lunny
reviewed
Dec 10, 2024
lunny
reviewed
Dec 10, 2024
lunny
reviewed
Dec 10, 2024
lunny
reviewed
Dec 10, 2024
| RightHunkSize: 4, | ||
| HasComments: false, | ||
| LastRightCommentIdx: 0, | ||
| RightCommentIdx: 0, |
There was a problem hiding this comment.
Please add a test which has the comment.
lunny
reviewed
Dec 10, 2024
| @@ -100,6 +101,13 @@ function initRepoDiffConversationForm() { | |||
| } | |||
| }); | |||
|
|
|||
| $(document).on('click', '.pull-request-diff-comments', async (e) => { | |||
There was a problem hiding this comment.
We have a plan to remove jquery. So new code should not use jquery any more.
…thub.com:rajesh-jonnalagadda/gitea into feat-32257-add-comments-unchanged-lines-and-show
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #32257
demo video: phase 1
https://www.loom.com/share/36284c2b94d7478eb9cc5fd3104d8511