Change typescript module to nodenext
#32757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
silverwind
added
the
skip-changelog
|
Typscript will be adding more suitable node targets like |
silverwind
changed the title
module to nodenext
|
Is |
As per TS docs,
In typescript 5.8 we can switch it to It is urgent in the sense that if we want |
wxiaoguang
approved these changes
Dec 9, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 10, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Dec 10, 2024
* origin/main: Fix internal server error when updating labels without write permission (go-gitea#32776) Fix wiki ui (go-gitea#32781) Change typescript `module` to `nodenext` (go-gitea#32757) Refactor issue filter (labels, poster, assignee) (go-gitea#32771) Make RepoActionView.vue support `##[group]` (go-gitea#32770) [skip ci] Updated translations via Crowdin
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 11, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Use batch database operations instead of one by one to optimze api pulls (go-gitea#32680) Fix internal server error when updating labels without write permission (go-gitea#32776) Fix wiki ui (go-gitea#32781) Change typescript `module` to `nodenext` (go-gitea#32757) Refactor issue filter (labels, poster, assignee) (go-gitea#32771)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 5.7 changed semantics around JSON imports and
nodenextis now treated differently thannode16for JSON imports and it requires the import attribute, so change the value to that and add the attribute to eliminate this typescript error.moduleResolutionis treated as an alias whenmoduleisnodenext, so we don't need to specify it.Also see microsoft/TypeScript#60589. It appears the next Typescript release will fix this for
node16, but I guess it'll still be good to switch tonodenext.