Detect whether action view branch was deleted #32764
Merged
+69
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
modifies/go
metiftikci
reviewed
Dec 8, 2024
|
Not do it in In |
pull-request-size
bot
added
size/M
github-actions
bot
added
the
modifies/templates
Done in 890863f |
Zettat123
approved these changes
Dec 10, 2024
GiteaBot
added
lgtm/need 1
yp05327
reviewed
Dec 10, 2024
delvh
reviewed
Dec 11, 2024
delvh
approved these changes
Dec 11, 2024
GiteaBot
added
lgtm/done
wxiaoguang
reviewed
Dec 11, 2024
wxiaoguang
reviewed
Dec 11, 2024
wxiaoguang
reviewed
Dec 11, 2024
routers/web/repo/actions/actions.go
Outdated
| if refName.IsBranch() { | ||
| branchName := refName.ShortName() | ||
| run.IsRefDeleted = true // assume it's deleted then if it's found in the database it's not deleted | ||
| branchRuns[branchName] = append(branchRuns[branchName], run) |
There was a problem hiding this comment.
Is it right? What if a branch starts 2 runs?
There was a problem hiding this comment.
And since the logic seems fragile, I think it needs tests
There was a problem hiding this comment.
Is it right? What if a branch starts 2 runs?
A branch could start multiple runs, feature branches maybe updated multiple times and main branches may merge many commits. All these behaviours will trigger action runs.
wxiaoguang
reviewed
Dec 11, 2024
…/gitea into lunny/detect_action_branch_deleted
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32761