Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard-compliant route to serve outdated R packages #32783

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

Sebastian-T-T
Copy link
Contributor

The R package repository currently does not have support for older versions of packages which should be stored in a separate /Archive router. This PR remedies that by adding a new path router.

I am a member of a group that loves using Gitea and this bug has been annoying us for a long time. Hope it can be merged in time for Gitea 1.23.0.

Any feedback much appreciated.

Fixes #32782

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 10, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 10, 2024
routers/api/packages/api.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Dec 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2024
@delvh delvh changed the title FIx issue with R packages not being served from Archive router as expected by R package managers Add route to serve outdated R packages Dec 11, 2024
@delvh delvh changed the title Add route to serve outdated R packages Add standard-compliant route to serve outdated R packages Dec 11, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2024
@lunny lunny enabled auto-merge (squash) December 11, 2024 15:53
@lunny lunny added this to the 1.23.0 milestone Dec 11, 2024
@lunny lunny merged commit 874b848 into go-gitea:main Dec 11, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 11, 2024
…2783)

The R package repository currently does not have support for older
versions of packages which should be stored in a separate /Archive
router. This PR remedies that by adding a new path router.

I am a member of a group that loves using Gitea and this bug has been
annoying us for a long time. Hope it can be merged in time for Gitea
1.23.0.

Any feedback much appreciated.

Fixes go-gitea#32782
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 11, 2024
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 11, 2024
wxiaoguang pushed a commit that referenced this pull request Dec 11, 2024
…32789)

Backport #32783 by Sebastian-T-T

The R package repository currently does not have support for older
versions of packages which should be stored in a separate /Archive
router. This PR remedies that by adding a new path router.

Fixes #32782

Co-authored-by: Sebastian T. T. <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2024
* giteaofficial/main:
  Switch to `eslint-plugin-import-x` (go-gitea#32790)
  Fix clone panel js error (go-gitea#32798)
  [skip ci] Updated translations via Crowdin
  Add `is_archived` option for issue indexer (go-gitea#32735)
  Upgrade dependency crypto library (go-gitea#32750)
  Add standard-compliant route to serve outdated R packages (go-gitea#32783)
  Fix repo home file list (go-gitea#32788)
  Rearrange Clone Panel (go-gitea#31142)
  Fix a number of typescript errors (go-gitea#32773)
  Add label/author/assignee filters to the user/org home issue list (go-gitea#32779)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CRAN package registry not working when requesting archived packages
5 participants