Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal server error when updating labels without write permission (#32776) #32785

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #32776 by @yp05327

Fix #32775

if permission denined, prepareForReplaceOrAdd will return nothing, and this case is not handled.

…on (go-gitea#32776)

Fix go-gitea#32775

if permission denined, `prepareForReplaceOrAdd` will return nothing, and
this case is not handled.
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Dec 10, 2024
@GiteaBot GiteaBot requested review from lunny and Zettat123 December 10, 2024 21:15
@GiteaBot GiteaBot added this to the 1.22.5 milestone Dec 10, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 10, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2024
@lunny lunny merged commit 0c7e44f into go-gitea:release/v1.22 Dec 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants