Rewrite compare functions #32786
Draft
Rewrite compare functions #32786
+686
−542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
lunny
commented
Dec 10, 2024
modules/git/repo_compare.go
Outdated
| @@ -329,21 +320,6 @@ func (repo *Repository) GetFilesChangedBetween(base, head string) ([]string, err | |||
| return split, err | |||
| } | |||
|
|
|||
| // GetDiffFromMergeBase generates and return patch data from merge base to head | |||
wxiaoguang
reviewed
Dec 10, 2024
services/pull/patch.go
Outdated
Comment on lines
32
to
41
| // getDiffOrPatch generates either diff or formatted patch data between given revisions | ||
| func getDiffOrPatch(repo *git.Repository, compareString string, w io.Writer, patch, binary bool) error { | ||
| if patch { | ||
| return repo.GetPatch(compareString, w) | ||
| } | ||
| if binary { | ||
| return repo.GetDiffBinary(compareString, w) | ||
| } | ||
| return repo.GetDiff(compareString, w) | ||
| } |
There was a problem hiding this comment.
There is only one call to this function? Maybe it could be removed and just write the if/else in the caller.
pull-request-size
bot
added
size/XXL
github-actions
bot
added
the
modifies/api
lunny
changed the title
lunny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.