Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixe a keystring misuse and refactor duplicates keystrings (#32668) #32792

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 11, 2024

Backport #32668

…s keystrings (go-gitea#32668)

- Fixes a translation keystring misuse where the string 'open
milestones' is used in place of 'closed milestones'.
- De-duplicates the use of 'open milesones' and 'closed milestones'
keystrings on the sidebar of an issue, reusing the ones on the issues
filter and action bars.
- Closes go-gitea#32667

---------

Co-authored-by: wxiaoguang <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 11, 2024
@GiteaBot GiteaBot added this to the 1.22.5 milestone Dec 11, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2024
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels Dec 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2024
@techknowlogick techknowlogick merged commit 6092bba into go-gitea:release/v1.22 Dec 11, 2024
25 of 26 checks passed
@lunny lunny deleted the lunny/backport_32668 branch December 11, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/templates This PR modifies the template files modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants