-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid MacOS keychain dialog in integration tests #32813
Merged
techknowlogick
merged 3 commits into
go-gitea:main
from
bohde:rb/dont-popup-keychain-in-integration-tests
Dec 12, 2024
Merged
Avoid MacOS keychain dialog in integration tests #32813
techknowlogick
merged 3 commits into
go-gitea:main
from
bohde:rb/dont-popup-keychain-in-integration-tests
Dec 12, 2024
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 12, 2024
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Dec 12, 2024
bohde
changed the title
avoid MacOS keychain dialog in integration tests
Avoid MacOS keychain dialog in integration tests
Dec 12, 2024
lunny
approved these changes
Dec 12, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 12, 2024
techknowlogick
approved these changes
Dec 12, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Dec 12, 2024
techknowlogick
added
backport/v1.22
This PR should be backported to Gitea 1.22
and removed
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
labels
Dec 12, 2024
techknowlogick
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 12, 2024
GiteaBot
added
the
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
label
Dec 12, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 12, 2024
Mac's git installation ships with a system wide config that configures the credential helper `osxkeychain`, which will prompt the user with a dialog. ``` $ git config list --system credential.helper=osxkeychain ``` By setting the environment variable [`GIT_CONFIG_NOSYSTEM=true`](https://git-scm.com/docs/git-config#ENVIRONMENT), Git will not load the system wide config, preventing the dialog from populating. Closes go-gitea#26717
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Dec 12, 2024
lunny
pushed a commit
that referenced
this pull request
Dec 12, 2024
Backport #32813 by @bohde Mac's git installation ships with a system wide config that configures the credential helper `osxkeychain`, which will prompt the user with a dialog. ``` $ git config list --system credential.helper=osxkeychain ``` By setting the environment variable [`GIT_CONFIG_NOSYSTEM=true`](https://git-scm.com/docs/git-config#ENVIRONMENT), Git will not load the system wide config, preventing the dialog from populating. Closes #26717 Co-authored-by: Rowan Bohde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/v1.22
This PR should be backported to Gitea 1.22
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac's git installation ships with a system wide config that configures the credential helper
osxkeychain
, which will prompt the user with a dialog.By setting the environment variable
GIT_CONFIG_NOSYSTEM=true
, Git will not load the system wide config, preventing the dialog from populating.Closes #26717