Included variables using common names are getting overriden

[nick-jones]

Apologies if this is an intentional change, or we were previously relying on functionality in a way we shouldn't have been.

Before v3.37.0, it was possible to have 2 Taskfile includes declare variables with the same name, as these were treated in isolation. As a very basic example:

./Taskfile.yaml

version: "3"

includes:
  foo:
    taskfile: ./foo/Taskfile.yaml
  bar:
    taskfile: ./bar/Taskfile.yaml

tasks:
  stub:
    cmds:
      - echo 0

./foo/Taskfile.yaml

version: "3"

vars:
  DIR: foo

tasks:
  pwd:
    dir: ./{{ .DIR }}
    cmds:
      - echo "{{ .DIR }}"
      - pwd

./bar/Taskfile.yaml

version: "3"

vars:
  DIR: bar

tasks:
  pwd:
    dir: ./{{ .DIR }}
    cmds:
      - echo "{{ .DIR }}"
      - pwd

So both includes declare a DIR variable. Previously these would not conflict with each other, at least from my observations:

<snip>
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo

However, as of the latest release, I see that DIR is sometimes confused with the value declared in the other include:

<snip>
/Users/nj/scratch/task/bar
$ task foo:pwd
task: [foo:pwd] echo "bar"
bar
task: [foo:pwd] pwd
/Users/nj/scratch/task/bar
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "bar"
bar
task: [foo:pwd] pwd
/Users/nj/scratch/task/bar

I'm not expecting bar to be referenced here at all.

---

• Task version: v3.37.1
• Operating system: OSX
• Experiments enabled: none

[csmith-n1]

Apologies if this is an intentional change, or we were previously relying on functionality in a way we shouldn't have been.

Before v3.37.0, it was possible to have 2 Taskfile includes declare variables with the same name, as these were treated in isolation. As a very basic example:

./Taskfile.yaml

version: "3"

includes:
  foo:
    taskfile: ./foo/Taskfile.yaml
  bar:
    taskfile: ./bar/Taskfile.yaml

tasks:
  stub:
    cmds:
      - echo 0

./foo/Taskfile.yaml

version: "3"

vars:
  DIR: foo

tasks:
  pwd:
    dir: ./{{ .DIR }}
    cmds:
      - echo "{{ .DIR }}"
      - pwd

./bar/Taskfile.yaml

version: "3"

vars:
  DIR: bar

tasks:
  pwd:
    dir: ./{{ .DIR }}
    cmds:
      - echo "{{ .DIR }}"
      - pwd

So both includes declare a DIR variable. Previously these would not conflict with each other, at least from my observations:

<snip>
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo

However, as of the latest release, I see that DIR is sometimes confused with the value declared in the other include:

<snip>
/Users/nj/scratch/task/bar
$ task foo:pwd
task: [foo:pwd] echo "bar"
bar
task: [foo:pwd] pwd
/Users/nj/scratch/task/bar
$ task foo:pwd
task: [foo:pwd] echo "foo"
foo
task: [foo:pwd] pwd
/Users/nj/scratch/task/foo
$ task foo:pwd
task: [foo:pwd] echo "bar"
bar
task: [foo:pwd] pwd
/Users/nj/scratch/task/bar

I'm not expecting bar to be referenced here at all.

• Task version: v3.37.1
• Operating system: OSX
• Experiments enabled: none

Yes, discovered the same issue. Currently pinning previous version. 😢

[Jayden-58]

I am experiencing this as well. Currently pinning to v3.36.0 as that was the pervious version to work for me. thanks @csmith-n1!

[pd93]

I've created a fix for this in #1649.

@nick-jones, @csmith-n1, @Jayden-58 and any others following this, if you're running go, you can test the fix out by installing Task with:

go install github.com/go-task/task/v3/cmd/task@37f32cc