Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: add offline status #1019

Open
jbrockopp opened this issue Oct 28, 2024 · 1 comment
Open

worker: add offline status #1019

jbrockopp opened this issue Oct 28, 2024 · 1 comment
Labels
enhancement Indicates an improvement to a feature status/reviewed Indicates the item has been reviewed

Comments

@jbrockopp
Copy link
Contributor

Description

For context, we currently deploy our Vela workers with autoscaling configuration enabled so this means our workers will periodically scale up and down throughout the day based off the activity and build volume for our installation. However, this unfortunately leads to some challenges when attempting to leverage the new workers page introduced in the 0.24 release of Vela because the data can become inaccurate and out-of-sync very quickly. We're looking to update the workers page for our installation so it better reflects current state and get closer to near real-time information on it:

image

There are two main pieces we're looking to update on this page for each record in the workers table:

  • the active field being set to false to denote that the worker is no longer active and never will be
  • the status field being set to something to denote that the worker is no longer active and never will be

As we were exploring the current enum list available for the status field, we felt there wasn't an ideal one to pick from:

https://github.com/go-vela/types/blob/v0.24.0/constants/worker_status.go

To better state that in words, given the current list I linked above our options are:

  • available
  • busy
  • idle
  • error

From our perspective, it seems confusing to have a worker in an idle status that has active as false (no in UI). We'd like to request that a new status be added that we could update workers to and some initial ideas we had were:

  • decommissioned
  • offline
  • shutdown

Value

  • enable admins of Vela installations to better reflect the status of workers that will never be available/idle again

Definition of Done

  • a new enum has been added to the list of worker statuses that reflects a worker is offline

Effort (Optional)

  • unsure at this time

Impacted Personas (Optional)

  • admins of a Vela installation
@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Oct 28, 2024
@chrispdriscoll
Copy link
Contributor

We reviewed as a team and felt like your naming ideas were good (no strong opinions otherwise).

Do you plan to submit this change?

@chrispdriscoll chrispdriscoll added the status/reviewed Indicates the item has been reviewed label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature status/reviewed Indicates the item has been reviewed
Projects
None yet
Development

No branches or pull requests

2 participants