Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local ACS urls falsefully rejected #12785

Open
ludwigkraatz opened this issue Jan 23, 2025 · 1 comment
Open

local ACS urls falsefully rejected #12785

ludwigkraatz opened this issue Jan 23, 2025 · 1 comment

Comments

@ludwigkraatz
Copy link

ludwigkraatz commented Jan 23, 2025

An URL that is compliant to RFC 3986 (URL/URI RFC) and especially is compliant with RFC 6762 (mDNS) is rejected, even though it should not be.

In Detail:

django URLValidator only excepts Non-FQDN: "localhost".
This is a dirty fix. But actually in many scenarios (intranet, local DNS, mDNS) no FQDN is required or desirable.

When wanting to authenticate a ACS URL that matches that criteria - this is an issue.

I created a pull request for django django/django#19095.

So - maybe one of you can lobby for that change - or knows about a quicker solution in authentik itself?!

Thanks for your work!!

best regard
ludwig

EDIT: created django TRAC ticket: https://code.djangoproject.com/ticket/36131

@ludwigkraatz ludwigkraatz changed the title local urls falsefully rejected local ACS urls falsefully rejected Jan 23, 2025
@ludwigkraatz
Copy link
Author

acs_url = models.URLField(verbose_name=_("ACS URL"))

that reference should have been part of the issue - dont know why github didnt include it..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant