Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull translations before each release #12902

Open
davidmehren opened this issue Jan 31, 2025 · 8 comments
Open

Pull translations before each release #12902

davidmehren opened this issue Jan 31, 2025 · 8 comments
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request pr_wanted Will eventually be fixed/implemented upstream, PRs will happily be accepted.

Comments

@davidmehren
Copy link

Describe the bug

At least the string with id s670ad066cc0e50a3 for the German translation was updated in Transifex in March 2024, but that change was not imported into this repo.

To Reproduce
Steps to reproduce the behavior:

  1. Look at the string in web/xliff/de.xlf: https://github.com/goauthentik/authentik/blame/main/web/xliff/de.xlf#L4908
  2. Observe no space after the <x id="0" equiv-text="${this.challenge.applicationPre}"/> placeholder and the blame showing the last change at two years ago.

Image

  1. Check the same string in Transifex and observe the missing space has been added a year ago: https://app.transifex.com/authentik/authentik/translate/#de/c2121861c815af81d0bc88d61b4a85fe/460443676?q=text%3A'login+to'

Image

  1. Wonder if Transifex changes get imported correctly

Expected behavior

All translation changes get imported to the repo and eventually released.

@davidmehren davidmehren added the bug Something isn't working label Jan 31, 2025
@rissson
Copy link
Member

rissson commented Jan 31, 2025

Changes are only pulled in once the translation is 100% done

@rissson rissson added question Further information is requested and removed bug Something isn't working labels Jan 31, 2025
@davidmehren
Copy link
Author

So you are continuing to ship a translation, but not any updates to it, as soon as it is not 100% translated anymore?

That does seem quite weird to me.

@davidmehren
Copy link
Author

I think it is very sensible to only start shipping a translation when it is 100% done.

But in this case you are shipping an evidently broken German translation (see e.g. #10892), point people to fix it in Transifex, but don't ship the fixes.

Isn't it possible to always pull updates for a language after you shipped it initially?

@rissson
Copy link
Member

rissson commented Jan 31, 2025

I'm not entirely certain, but this might be a transifex limitation, at least when using the built-in integration with github. If we need to build a custom thing to pull in translations, we simply don't have the bandwidth to do so right now.

@rissson
Copy link
Member

rissson commented Jan 31, 2025

Image

Yeah indeed, we're currently setting this to 100% translated. We could put it at an arbitrary number like 75%, but then each update would trigger a new PR on this repository, which is untenable

@davidmehren
Copy link
Author

At HedgeDoc, we at some point ditched the POEditor integration and started to pull translation changes manually before each release. Maybe this is something you could consider?

@rissson
Copy link
Member

rissson commented Jan 31, 2025

Definitely, especially if there's some prior art for how to do it. For now I'll mark this as planned, but don't expect us to tackle this soon. Community contributions are welcomed though

@rissson rissson added enhancement New feature or request pr_wanted Will eventually be fixed/implemented upstream, PRs will happily be accepted. enhancement/confirmed Enhancements that will be implemented in the future and removed question Further information is requested labels Jan 31, 2025
@rissson rissson changed the title Translation changes from Transifex don't seem to be synced to the repo Pull translations before each release Jan 31, 2025
@strifel
Copy link

strifel commented Jan 31, 2025

Zulip does also pull translations manually from transifex: https://github.com/zulip/zulip/blob/main/tools/i18n/sync-translations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/confirmed Enhancements that will be implemented in the future enhancement New feature or request pr_wanted Will eventually be fixed/implemented upstream, PRs will happily be accepted.
Projects
None yet
Development

No branches or pull requests

3 participants