-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull translations before each release #12902
Comments
Changes are only pulled in once the translation is 100% done |
So you are continuing to ship a translation, but not any updates to it, as soon as it is not 100% translated anymore? That does seem quite weird to me. |
I think it is very sensible to only start shipping a translation when it is 100% done. But in this case you are shipping an evidently broken German translation (see e.g. #10892), point people to fix it in Transifex, but don't ship the fixes. Isn't it possible to always pull updates for a language after you shipped it initially? |
I'm not entirely certain, but this might be a transifex limitation, at least when using the built-in integration with github. If we need to build a custom thing to pull in translations, we simply don't have the bandwidth to do so right now. |
At HedgeDoc, we at some point ditched the POEditor integration and started to pull translation changes manually before each release. Maybe this is something you could consider? |
Definitely, especially if there's some prior art for how to do it. For now I'll mark this as planned, but don't expect us to tackle this soon. Community contributions are welcomed though |
Zulip does also pull translations manually from transifex: https://github.com/zulip/zulip/blob/main/tools/i18n/sync-translations |
Describe the bug
At least the string with id
s670ad066cc0e50a3
for the German translation was updated in Transifex in March 2024, but that change was not imported into this repo.To Reproduce
Steps to reproduce the behavior:
web/xliff/de.xlf
: https://github.com/goauthentik/authentik/blame/main/web/xliff/de.xlf#L4908<x id="0" equiv-text="${this.challenge.applicationPre}"/>
placeholder and the blame showing the last change at two years ago.Expected behavior
All translation changes get imported to the repo and eventually released.
The text was updated successfully, but these errors were encountered: