replace TypeList with TypeSet for idempotency #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! usually |
|
Has this been solved yet, since I'm still observing some idempotency issues. If I can help in any way or form let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #377
Warning: I don't know how to write golang, but it's 2023 and we have AI now.
This is what it came up with. I built and tested this code and it does appear to resolve the issue reported in #377.
I feel like a patient going to a doctor with a printed out WebMD diagnosis. I'm sorry for doing it this way but I figured it might save you some time. I'm just trying to be helpful in the only way I know how.