Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/full-ci: allow manually triggering the workflow (mostly useful for forks) #933

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

0x53A
Copy link
Contributor

@0x53A 0x53A commented Oct 27, 2024

First I added this temporarily to my WIP branch with the intention to back it out before merge, but maybe it would make sense to also add this to master.

I wanted to be able to run CI in my fork, and this allows triggering the workflow on a branch manually

image

@0x53A 0x53A changed the title workflows/full-ci: allow manually triggering the workflow workflows/full-ci: allow manually triggering the workflow (mostly useful for forks) Oct 27, 2024
@Bromeon Bromeon added quality-of-life No new functionality, but improves ergonomics/internals c: tooling CI, automation, tools labels Oct 27, 2024
@GodotRust
Copy link

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-933

@Bromeon
Copy link
Member

Bromeon commented Nov 5, 2024

Thanks! This can be a nice addition. 🙂

Did you encounter any caveats?

One thing I could imagine is that if the full-ci.yml has any statements that rely on it (unconditionally) being a PR, that would no longer work -- but I'm OK with considering that ill-formed.

If we add this, we should maybe mention it in the book, otherwise it's quite hard to discover:
https://godot-rust.github.io/book/contribute/dev-tools.html

@0x53A
Copy link
Contributor Author

0x53A commented Nov 6, 2024

yeah makes sense I'll add a sentence to the book (https://github.com/godot-rust/book/blob/master/src/contribute/dev-tools.md#continuous-integration).


I did not encounter any issues; from skimming the workflow definition, it doesn't reference the current PR.

here is one example run: https://github.com/0x53A/gdext/actions/runs/11534881310

image


Not related to this PR, but related to CI in general, the workflow Compile + Sync Docs also gets executed on forks if GH Actions are enabled (since the trigger is "push to master").

https://github.com/0x53A/gdext/actions/runs/11534878151/workflow

might make sense to add an if: github.repository == 'godot-rust/gdext'

@Bromeon Bromeon added this pull request to the merge queue Nov 7, 2024
Merged via the queue into godot-rust:master with commit 8beef9d Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: tooling CI, automation, tools quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants